> On April 29, 2013, 4:10 p.m., Edward Sargisson wrote:
> > flume-ng-doc/sphinx/FlumeUserGuide.rst, line 31
> > <https://reviews.apache.org/r/10817/diff/1/?file=285292#file285292line31>
> >
> >     "not only restricted" doesn't make sense in this context. Consider "is 
> > not restricted to".

Thanks I will fix this 


> On April 29, 2013, 4:10 p.m., Edward Sargisson wrote:
> > flume-ng-doc/sphinx/FlumeUserGuide.rst, line 33
> > <https://reviews.apache.org/r/10817/diff/1/?file=285292#file285292line33>
> >
> >     Commas need to be inserted for correct grammar. "including, but not 
> > limited to, network"

This will be addressed.


> On April 29, 2013, 4:10 p.m., Edward Sargisson wrote:
> > flume-ng-doc/sphinx/FlumeUserGuide.rst, line 34
> > <https://reviews.apache.org/r/10817/diff/1/?file=285292#file285292line34>
> >
> >     Correct me if I'm wrong but Flume may have a problem if the size of 
> > each event gets too large? I'm not sure what might be too large but the 
> > software is designed with a log line in mind - and a log line might only 
> > get to a few KB.

Just like how SpoolDirectorySource is configured, limits for event size can be 
set so that occurrences that exceed that threshold will be truncated.


- Israel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10817/#review19860
-----------------------------------------------------------


On April 28, 2013, 5:24 a.m., Israel Ekpo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10817/
> -----------------------------------------------------------
> 
> (Updated April 28, 2013, 5:24 a.m.)
> 
> 
> Review request for Flume.
> 
> 
> Description
> -------
> 
> FLUME-2030 - Documentation of Configuration Changes JMSSource, HBaseSink, 
> AsyncHBaseSink and ElasticSearchSink
> 
> - Updated user guide to illustrate the replacement of FQCNs with enum 
> constants (lowercased) for built-in sources and sinks.
> - Added System Requirements needed to run Flume.
> - Added documentation to encourage users to migrate to 1.x from 0.9.x so as 
> to take advantage of improvements available in Flume NG
> - Added documentation to inform users that Apache Flume is not limited only 
> to log data aggregation.
> 
> 
> This addresses bugs FLUME-1886, FLUME-1889, FLUME-1994, and FLUME-2030.
>     https://issues.apache.org/jira/browse/FLUME-1886
>     https://issues.apache.org/jira/browse/FLUME-1889
>     https://issues.apache.org/jira/browse/FLUME-1994
>     https://issues.apache.org/jira/browse/FLUME-2030
> 
> 
> Diffs
> -----
> 
>   flume-ng-doc/sphinx/FlumeUserGuide.rst 38f2205 
> 
> Diff: https://reviews.apache.org/r/10817/diff/
> 
> 
> Testing
> -------
> 
> N/A
> 
> 
> Thanks,
> 
> Israel Ekpo
> 
>

Reply via email to