Thanks for the additional information, Brock. I will keep that in mind when creating the JIRA improvement issues.
I will be creating the JIRA issues soon and I will reply to this thread with a list of affected modules and the files for each issue created. This will give others an opportunity to submit feedback before any patches are submitted. On 1 May 2013 08:29, Brock Noland <[email protected]> wrote: > Hey, this looks good to me! > > One thing though, we do check in generated source code for > Thrift/Protobuf/Avro e.g. ThriftFlumeEvent.java. Can we remove these > classes from the cleanup? The changes will just get overwritten the next > time we generate the code. > > Brock > > > On Wed, May 1, 2013 at 6:58 AM, Israel Ekpo <[email protected]> wrote: > > > Flumologists, > > > > I wanted to get some feedback from others before proceeding with this. > > > > So, I recently opened a JIRA issue and submitted a patch that removes > > unwanted imports from the project. > > > > https://issues.apache.org/jira/browse/FLUME-2031 > > > > I was thinking about doing the same cleanup for unused variables/fields, > > references to generic types that should be > > parametized, unnecessary @SuppressWarning annotations etc. > > > > I came into these warnings in the files as I was going around adding > > javadocs and other documenation to the files. > > > > Is this cleanup something that will be helpful? > > > > If so then I can open another JIRA issue and upload patches for just the > > clean up changes. > > > > > > -- > Apache MRUnit - Unit testing MapReduce - http://mrunit.apache.org >
