----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11066/#review20441 -----------------------------------------------------------
This looks good to me, I think simple is fine also. There is a minor typo that should be corrected below though, but it doesn't really affect the validity of the tests. flume-ng-clients/flume-ng-log4jappender/src/test/java/org/apache/flume/clients/log4jappender/TestLog4jAppender.java <https://reviews.apache.org/r/11066/#comment42121> I think you meant "throw new RuntimeException(ex)" here - Mike Percy On May 11, 2013, 12:23 a.m., Hari Shreedharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11066/ > ----------------------------------------------------------- > > (Updated May 11, 2013, 12:23 a.m.) > > > Review request for Flume. > > > Description > ------- > > Added timeout configuration to both log4j appender and load balancing log4j > appender > > > This addresses bug FLUME-2042. > https://issues.apache.org/jira/browse/FLUME-2042 > > > Diffs > ----- > > > flume-ng-clients/flume-ng-log4jappender/src/main/java/org/apache/flume/clients/log4jappender/LoadBalancingLog4jAppender.java > 3172e21 > > flume-ng-clients/flume-ng-log4jappender/src/main/java/org/apache/flume/clients/log4jappender/Log4jAppender.java > 0ba56d3 > > flume-ng-clients/flume-ng-log4jappender/src/test/java/org/apache/flume/clients/log4jappender/TestLoadBalancingLog4jAppender.java > 103bcb6 > > flume-ng-clients/flume-ng-log4jappender/src/test/java/org/apache/flume/clients/log4jappender/TestLog4jAppender.java > 211837b > > Diff: https://reviews.apache.org/r/11066/diff/ > > > Testing > ------- > > Added new unit tests. Ran full build, all tests pass. > > > Thanks, > > Hari Shreedharan > >
