[ 
https://issues.apache.org/jira/browse/FLUME-1899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13669544#comment-13669544
 ] 

Phil Scala edited comment on FLUME-1899 at 5/29/13 6:36 PM:
------------------------------------------------------------

Attached is my first patch for this issue (the patch is against the v1.4 code 
base).  I will continue to run some more tests.

The patch details:

-  A new property has been added to the SpoolDirectorySource (property name: 
recursiveDirectorySearch)
- the default for this setting is "false"...meaning its not enabled by default 
so there are no wierd side effects when moving from 1.3 to 1.4 flume agents.
- when going through directories, ignored are:
-- directories starting with "." ...  
-- any directories that match the ignore pattern (same pattern as the file 
ignore pattern)
- 2 new unit tests were created for this feature. 
- FlumeUserGuide updated with this new property


I waffled on one change and will chat over the dev mailing list...

the FileFilter was an anonymous instance created inline, my changes made it 
double in size, so I made the filter a final instance member...comments on that 
welcome

                
      was (Author: scaph01):
    Attached is my first patch for this issue.  I will continue to run some 
more tests.

The patch details:

-  A new property has been added to the SpoolDirectorySource (property name: 
recursiveDirectorySearch)
- the default for this setting is "false"...meaning its not enabled by default 
so there are no wierd side effects when moving from 1.3 to 1.4 flume agents.
- when going through directories, ignored are:
-- directories starting with "." ...  
-- any directories that match the ignore pattern (same pattern as the file 
ignore pattern)
- 2 new unit tests were created for this feature. 
- FlumeUserGuide updated with this new property


I waffled on one change and will chat over the dev mailing list...

the FileFilter was an anonymous instance created inline, my changes made it 
double in size, so I made the filter a final instance member...comments on that 
welcome

                  
> Make SpoolDir work with Sub-Directories
> ---------------------------------------
>
>                 Key: FLUME-1899
>                 URL: https://issues.apache.org/jira/browse/FLUME-1899
>             Project: Flume
>          Issue Type: Improvement
>          Components: Sinks+Sources
>    Affects Versions: v1.3.1
>            Reporter: Tzur Turkenitz
>            Assignee: Phil Scala
>            Priority: Minor
>              Labels: Sources, SpoolDir
>         Attachments: FLUM-1899-1.patch
>
>
> SpoolrDir currently monitors a directory and can not handle sub-directories. 
> This JIRA is to make SpoolDir able to walk down a source directory and 
> monitor new files.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to