[ 
https://issues.apache.org/jira/browse/FLUME-2007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13678497#comment-13678497
 ] 

Hari Shreedharan commented on FLUME-2007:
-----------------------------------------

Thanks Ted. I have one question. Looks like there is a sleep for 1 minute 
between retry attempts. Note that since this is being called on a thread timing 
out based on the hdfs timeout, this time between retries would cause issues, 
right? I mean if you retry once a minute and the timeout is 30 seconds - there 
would never be a retry. Do you think it might make sense for the time between 
retries be something like 1/nth of the timeout (n being max retry attempts) - 
so n retries can be completed within the timeout itself. I think it is fine for 
that not to be configurable. Also it might make sense to put a ceiling on the 
max retry attempts - a value like 1000 or something in the config does not make 
a whole lot of sense. 
                
> HDFS Sink should check if file is closed and retry if it is not.
> ----------------------------------------------------------------
>
>                 Key: FLUME-2007
>                 URL: https://issues.apache.org/jira/browse/FLUME-2007
>             Project: Flume
>          Issue Type: Bug
>            Reporter: Hari Shreedharan
>            Assignee: Ted Malaska
>         Attachments: FLUME-2007-0.patch, FLUME-2007-1.patch
>
>
> We can use the new API added in HDFS-4525. We will need to use reflection 
> though, so we can run against a version of HDFS which does not have this API.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to