----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11822/#review22268 -----------------------------------------------------------
Ship it! +1, looks good to me and the unit tests pass. Personally I'm happy with a patch that only has the minimal changes required. I'm removing the unused import on commit. - Mike Percy On June 12, 2013, 4:19 p.m., Sravya Tirukkovalur wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11822/ > ----------------------------------------------------------- > > (Updated June 12, 2013, 4:19 p.m.) > > > Review request for Flume, Brock Noland, Mike Percy, and Hari Shreedharan. > > > Description > ------- > > Seq Generator Source supports following metrics: > START > STOP > EVENTS_ACCEPTED > APPEND_BATCH_ACCEPTED > > > This addresses bug FLUME-2082. > https://issues.apache.org/jira/browse/FLUME-2082 > > > Diffs > ----- > > > flume-ng-core/src/main/java/org/apache/flume/source/SequenceGeneratorSource.java > 0f85e87 > > Diff: https://reviews.apache.org/r/11822/diff/ > > > Testing > ------- > > Ran existing tests > > > Thanks, > > Sravya Tirukkovalur > >
