[
https://issues.apache.org/jira/browse/FLUME-1917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13691161#comment-13691161
]
Brock Noland commented on FLUME-1917:
-------------------------------------
Hey Hari,
Thanks for the patch! I think the patch will work, but I think there is a race
that could cause "extra" syncs? Let me know if I am off base:
{noformat}
thread-1 commit
thread-2 commit
thread-2 sync
thread-3 commit
thread-1 sync <- here thread-1 will do a sync if though it's required?
thread-3 sync
{noformat}
I think we could eliminate this by returning the offset from put/rollback and
then passing into sync?
> FileChannel group commit (coalesce fsync)
> -----------------------------------------
>
> Key: FLUME-1917
> URL: https://issues.apache.org/jira/browse/FLUME-1917
> Project: Flume
> Issue Type: Bug
> Components: File Channel
> Reporter: Hari Shreedharan
> Assignee: Hari Shreedharan
> Attachments: FLUME-1917.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
