[
https://issues.apache.org/jira/browse/FLUME-2094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13691385#comment-13691385
]
Mike Percy commented on FLUME-2094:
-----------------------------------
Hi Roshan, thanks for the update but your patch deletes a bunch of files that
it should not delete:
{noformat}
$ git status
# On branch trunk
# Changes not staged for commit:
# (use "git add/rm <file>..." to update what will be committed)
# (use "git checkout -- <file>..." to discard changes in working directory)
#
# deleted: flume-ng-channels/flume-recoverable-memory-channel/pom.xml
# deleted:
flume-ng-channels/flume-recoverable-memory-channel/src/main/java/org/apache/flume/channel/recoverable/memory/RecoverableMemoryChannel.java
# deleted:
flume-ng-channels/flume-recoverable-memory-channel/src/main/java/org/apache/flume/channel/recoverable/memory/RecoverableMemoryChannelEvent.java
# deleted:
flume-ng-channels/flume-recoverable-memory-channel/src/main/java/org/apache/flume/channel/recoverable/memory/wal/SequenceIDBuffer.java
# deleted:
flume-ng-channels/flume-recoverable-memory-channel/src/main/java/org/apache/flume/channel/recoverable/memory/wal/WAL.java
# deleted:
flume-ng-channels/flume-recoverable-memory-channel/src/main/java/org/apache/flume/channel/recoverable/memory/wal/WALDataFile.java
# deleted:
flume-ng-channels/flume-recoverable-memory-channel/src/main/java/org/apache/flume/channel/recoverable/memory/wal/WALEntry.java
# deleted:
flume-ng-channels/flume-recoverable-memory-channel/src/main/java/org/apache/flume/channel/recoverable/memory/wal/WALReplayResult.java
# deleted:
flume-ng-channels/flume-recoverable-memory-channel/src/test/java/org/apache/flume/channel/recoverable/memory/TestRecoverableMemoryChannel.java
# deleted:
flume-ng-channels/flume-recoverable-memory-channel/src/test/java/org/apache/flume/channel/recoverable/memory/wal/TestSequenceIDBuffer.java
# deleted:
flume-ng-channels/flume-recoverable-memory-channel/src/test/java/org/apache/flume/channel/recoverable/memory/wal/TestWAL.java
# deleted:
flume-ng-channels/flume-recoverable-memory-channel/src/test/resources/log4j.properties
# modified: flume-ng-channels/pom.xml
# modified:
flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelConfiguration.java
# modified:
flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelType.java
# modified: flume-ng-core/pom.xml
# deleted:
flume-ng-core/src/main/java/org/apache/flume/serialization/AvroEventDeserializer.java
# modified:
flume-ng-core/src/main/java/org/apache/flume/serialization/EventDeserializerType.java
# deleted:
flume-ng-core/src/main/java/org/apache/flume/serialization/LengthMeasurable.java
# deleted:
flume-ng-core/src/main/java/org/apache/flume/serialization/RemoteMarkable.java
# modified:
flume-ng-core/src/main/java/org/apache/flume/serialization/ResettableFileInputStream.java
# modified:
flume-ng-core/src/main/java/org/apache/flume/sink/RollingFileSink.java
# modified:
flume-ng-core/src/main/java/org/apache/flume/source/SequenceGeneratorSource.java
# modified:
flume-ng-core/src/main/java/org/apache/flume/source/SpoolDirectorySource.java
# modified:
flume-ng-core/src/main/java/org/apache/flume/source/ThriftSource.java
# deleted:
flume-ng-core/src/test/java/org/apache/flume/serialization/TestAvroEventDeserializer.java
# deleted:
flume-ng-core/src/test/java/org/apache/flume/serialization/TransientPositionTracker.java
# modified: flume-ng-dist/pom.xml
# modified: flume-ng-dist/src/main/assembly/bin.xml
# modified: flume-ng-doc/sphinx/FlumeUserGuide.rst
# modified: pom.xml
{noformat}
> Remove the deprecated - Recoverable Memory Channel
> --------------------------------------------------
>
> Key: FLUME-2094
> URL: https://issues.apache.org/jira/browse/FLUME-2094
> Project: Flume
> Issue Type: Task
> Components: Channel
> Affects Versions: v1.3.1
> Reporter: Roshan Naik
> Assignee: Roshan Naik
> Labels: channel, deprecated, deprecation
> Fix For: v1.4.0
>
> Attachments: FLUME-2094.patch
>
>
> Dropping the deprecated 'Recoverable Memory Channel' in v 1.4
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
