----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11811/#review22310 -----------------------------------------------------------
Ship it! +1, lgtm. Pulling this one into Flume 1.4.0. - Mike Percy On June 22, 2013, 12:38 a.m., Sravya Tirukkovalur wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11811/ > ----------------------------------------------------------- > > (Updated June 22, 2013, 12:38 a.m.) > > > Review request for Flume, Brock Noland, Mike Percy, and Hari Shreedharan. > > > Description > ------- > > Http Source supports following metrics: > START > STOP > OPEN_CONNECTION_COUNT > EVENTS_RECEIVED > EVENTS_ACCEPTED > > Some points for discussion: > 1. Should we support APPEND_BATCH_RECEIVED and APPEND_BATCH_ACCEPTED ? > Http doesnt have a batch setting, but multiple events can be sent in a single > POST request. > 2. Is EVENTS_RECEIVED always same as APPEND_RECEIVED? > Went over all the sources which support jmx metrics and it looks like they > are redundant and never actually used separately. > > > This addresses bug FLUME-2076. > https://issues.apache.org/jira/browse/FLUME-2076 > > > Diffs > ----- > > flume-ng-core/src/main/java/org/apache/flume/source/http/HTTPSource.java > a4c3eb3 > > Diff: https://reviews.apache.org/r/11811/diff/ > > > Testing > ------- > > Ran existing tests > > > Thanks, > > Sravya Tirukkovalur > >
