----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11583/#review22966 -----------------------------------------------------------
Hi Ted, This looks good. Could you please add the new param to the Flume user guide. Also a couple files are missing the ASF License header, which is required. I mentioned one other change below. flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/AbstractHDFSWriter.java <https://reviews.apache.org/r/11583/#comment46751> I think I mentioned this in the last review - could you please make this change: numberOfCloseRetries = context.getInteger("hdfs.closeTries", 1) - 1; This will ensure that the current behavior remains as is unless and until this parameter is actually set to be > 1. flume-ng-sinks/flume-hdfs-sink/src/test/java/org/apache/flume/sink/hdfs/MockFileSystemCloseRetryWrapper.java <https://reviews.apache.org/r/11583/#comment46749> Missing ASF license header flume-ng-sinks/flume-hdfs-sink/src/test/java/org/apache/flume/sink/hdfs/MockFsDataOutputStreamCloseRetryWrapper.java <https://reviews.apache.org/r/11583/#comment46750> Missing ASF license header. - Hari Shreedharan On July 10, 2013, 2:26 a.m., Ted Malaska wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11583/ > ----------------------------------------------------------- > > (Updated July 10, 2013, 2:26 a.m.) > > > Review request for Flume. > > > Bugs: 2007 > https://issues.apache.org/jira/browse/2007 > > > Repository: flume-git > > > Description > ------- > > We can use the new API added in HDFS-4525. We will need to use reflection > though, so we can run against a version of HDFS which does not have this API. > > > Diffs > ----- > > > flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/AbstractHDFSWriter.java > bc3b383 > > flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSCompressedDataStream.java > 2c2be6a > > flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSDataStream.java > b8214be > > flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSSequenceFile.java > 0383744 > > flume-ng-sinks/flume-hdfs-sink/src/test/java/org/apache/flume/sink/hdfs/MockFileSystemCloseRetryWrapper.java > PRE-CREATION > > flume-ng-sinks/flume-hdfs-sink/src/test/java/org/apache/flume/sink/hdfs/MockFsDataOutputStreamCloseRetryWrapper.java > PRE-CREATION > > flume-ng-sinks/flume-hdfs-sink/src/test/java/org/apache/flume/sink/hdfs/TestUseRawLocalFileSystem.java > ffbdde0 > > Diff: https://reviews.apache.org/r/11583/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > Patch-0 > > https://reviews.apache.org/media/uploaded/files/2013/05/31/FLUME-2007-0.patch > > > Thanks, > > Ted Malaska > >
