Thanks Alex ! Shall fix these and upload new patch.
On Wed, Jul 17, 2013 at 11:15 PM, Alexander Alten-Lorenz < [email protected]> wrote: > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12440/ > > flume-ng-core/src/main/java/org/apache/flume/source/http/HTTPSource.java<https://reviews.apache.org/r/12440/diff/1/?file=319796#file319796line124> > (Diff > revision 1) > > public class HTTPSource extends AbstractSource implements > > 124 > > Preconditions.checkArgument(sslPort != null && sslPort > 0, "SSL Port > cannot be null or less than 0" ); > > Whats about SSL port can't be < 0 or empty > > > > flume-ng-core/src/main/java/org/apache/flume/source/http/HTTPSource.java<https://reviews.apache.org/r/12440/diff/1/?file=319796#file319796line127> > (Diff > revision 1) > > public class HTTPSource extends AbstractSource implements > > 127 > > "Keystore is required for SSL > Conifguration" ); > > Whats about > A keystore is required .... > > A keystore password is .... > > > > flume-ng-doc/sphinx/FlumeUserGuide.rst<https://reviews.apache.org/r/12440/diff/1/?file=319799#file319799line1228> > (Diff > revision 1) > > 1228 > > keystore Location of the > keystore includng keystore file name > > Spelling issue: > > includng = including > > > - Alexander Alten-Lorenz > > On July 10th, 2013, 7:40 a.m. UTC, Ashish Paliwal wrote: > Review request for Flume. > By Ashish Paliwal. > > *Updated July 10, 2013, 7:40 a.m.* > *Bugs: * FLUME-2109 <https://issues.apache.org/jira/browse/FLUME-2109> > *Repository: * flume-git > Description > > Flume patch to support HTTPS support. Review comments incorporated. Now only > one mode shall be enabled either normal HTTP or HTTPS. > > Testing > > Unit test case added to verify SSL functionality. > > Diffs > > - flume-ng-core/src/main/java/org/apache/flume/source/http/HTTPSource.java > (c90f067) > - > flume-ng-core/src/main/java/org/apache/flume/source/http/HTTPSourceConfigurationConstants.java > (f547e0f) > - > flume-ng-core/src/test/java/org/apache/flume/source/http/TestHTTPSource.java > (8952db3) > - flume-ng-doc/sphinx/FlumeUserGuide.rst (63cad21) > > View Diff <https://reviews.apache.org/r/12440/diff/> > -- thanks ashish Blog: http://www.ashishpaliwal.com/blog My Photo Galleries: http://www.pbase.com/ashishpaliwal
