[
https://issues.apache.org/jira/browse/FLUME-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13714996#comment-13714996
]
Alexander Alten-Lorenz commented on FLUME-1336:
-----------------------------------------------
Sergey: Some nits:
1) Please add the apache license to all new files.
2) The file prunsrv.exe is a binary file, do this have any additional licenses
(commercial Microsoft, Tomcat, JBoss)?
3) Could you please open a review request per https://reviews.apache.org
(Project Flume-git)?
Technically the patch looks great and works as expected. We need to get sure
that we don't violate any propriety licenses, and that all files are shipped
with Apache License.
Thanks in advance,
Alex
> Create a Windows Service for flume (fully manageable)
> -----------------------------------------------------
>
> Key: FLUME-1336
> URL: https://issues.apache.org/jira/browse/FLUME-1336
> Project: Flume
> Issue Type: Improvement
> Reporter: Alexander Alten-Lorenz
> Assignee: Alexander Alten-Lorenz
> Attachments: FLUME-1336.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
