I shall create a JIRA to track it. This patch had too many iteration :) I shall look at the code coverage as well and that shall identify any other missing paths.
does it work? On Fri, Aug 2, 2013 at 4:01 AM, Hari Shreedharan <[email protected]>wrote: > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12803/ > > Ashish, > > This looks ready to commit. I have a couple of requests - if you want me to > commit this one, and complete the test in a follow-up jira, that is fine by > me too. > > > > flume-ng-core/src/main/java/org/apache/flume/source/http/HTTPSource.java<https://reviews.apache.org/r/12803/diff/1/?file=324467#file324467line116> > (Diff > revision 1) > > public class HTTPSource extends AbstractSource implements > > 115 > > LOG.debug("SSL configuration enabled"); > > We should probably log this at INFO level. > > > > flume-ng-core/src/test/java/org/apache/flume/source/http/TestHTTPSource.java<https://reviews.apache.org/r/12803/diff/1/?file=324469#file324469line300> > (Diff > revision 1) > > 296 > > public void testHttps() throws Exception { > > Can you add one test where a non-SSL connection fails? > > > - Hari Shreedharan > > On July 22nd, 2013, 7:56 a.m. UTC, Ashish Paliwal wrote: > Review request for Flume. > By Ashish Paliwal. > > *Updated July 22, 2013, 7:56 a.m.* > *Bugs: * FLUME-2109 <https://issues.apache.org/jira/browse/FLUME-2109> > *Repository: * flume-git > Description > > Fix for Flume-2109, to support HTTPS. > Incorporates Review comments from Alex > Implementation refined to be as close to Avro Source, like SSL port is not to > be defined, the port value shall be used > Documentation updated to reflect the changes > > Testing > > Unit Test case written to test SSL functionality > > Diffs > > - flume-ng-core/src/main/java/org/apache/flume/source/http/HTTPSource.java > (c90f067) > - > flume-ng-core/src/main/java/org/apache/flume/source/http/HTTPSourceConfigurationConstants.java > (f547e0f) > - > flume-ng-core/src/test/java/org/apache/flume/source/http/TestHTTPSource.java > (8952db3) > - flume-ng-doc/sphinx/FlumeUserGuide.rst (63cad21) > > View Diff <https://reviews.apache.org/r/12803/diff/> > -- thanks ashish Blog: http://www.ashishpaliwal.com/blog My Photo Galleries: http://www.pbase.com/ashishpaliwal
