> On Aug. 25, 2013, 12:46 a.m., Israel Ekpo wrote: > > Ship It!
I think for future reviews, we should try to add the branch (flume-1.4), this will make things easier to test out if the reviewer wishes to download the patch and test out the code without making assumptions about which branch the patch was created from. - Israel ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13509/#review25514 ----------------------------------------------------------- On Aug. 12, 2013, 10:19 p.m., Edward Sargisson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13509/ > ----------------------------------------------------------- > > (Updated Aug. 12, 2013, 10:19 p.m.) > > > Review request for Flume. > > > Repository: flume-git > > > Description > ------- > > The ElasticsearchSink is quite aggressive in assuming that the incoming event > is JSON. However, if it is not JSON or YAML then an exception is thrown which > would block the queue from processing further messages. > This patch catches Exception and writes the data as a simple field. > > > Diffs > ----- > > > flume-ng-sinks/flume-ng-elasticsearch-sink/src/main/java/org/apache/flume/sink/elasticsearch/ContentBuilderUtil.java > bf7c57c > > flume-ng-sinks/flume-ng-elasticsearch-sink/src/test/java/org/apache/flume/sink/elasticsearch/TestElasticSearchLogStashEventSerializer.java > 9dff4b0 > > Diff: https://reviews.apache.org/r/13509/diff/ > > > Testing > ------- > > Mvn install passes. > A custom build with this patch is currently running in many of our > environments with no problems and the event which caused the issue was safely > stored. > > > Thanks, > > Edward Sargisson > >
