----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14454/#review26657 -----------------------------------------------------------
Ship it! +1, looks good - Mike Percy On Oct. 3, 2013, 8:07 p.m., Hari Shreedharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14454/ > ----------------------------------------------------------- > > (Updated Oct. 3, 2013, 8:07 p.m.) > > > Review request for Flume. > > > Bugs: FLUME-2202 > https://issues.apache.org/jira/browse/FLUME-2202 > > > Repository: flume-git > > > Description > ------- > > Added a new config to coalesce increments. > > > Diffs > ----- > > flume-ng-doc/sphinx/FlumeUserGuide.rst 5a59b56 > > flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/AsyncHBaseSink.java > 5e297b1 > > flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/HBaseSinkConfigurationConstants.java > 7fdc75b > > flume-ng-sinks/flume-ng-hbase-sink/src/test/java/org/apache/flume/sink/hbase/IncrementAsyncHBaseSerializer.java > PRE-CREATION > > flume-ng-sinks/flume-ng-hbase-sink/src/test/java/org/apache/flume/sink/hbase/TestAsyncHBaseSink.java > a0c04eb > > Diff: https://reviews.apache.org/r/14454/diff/ > > > Testing > ------- > > All current tests pass. Added 2 new tests > > > Thanks, > > Hari Shreedharan > >
