[ 
https://issues.apache.org/jira/browse/FLUME-2159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13790969#comment-13790969
 ] 

Roshan Naik commented on FLUME-2159:
------------------------------------

I am thinking we should perhaps just drop this test. Its really flaky. Its 
really not accounting for the fact that threads are being spun up & terminated 
by other parts of the system. Its do not see a straightforward way  to fix this 
either..  it seems tricky to  exclude other threads in the count.

Here are some observations:
I see that sometimes (finalThreadCount > initialThreadCount), sometimes  it is 
(finalThreadCount < initialThreadCount) and at other times they are equal.

Here is an thread dump of a case where finalThreadCount =6 & 
initialThreadCount=5

{quote}
*Thread Dump Before*
    Thread: Reference Handler  ,Thd Id: 2
    Thread: Finalizer  ,Thd Id: 3
    Thread: Signal Dispatcher  ,Thd Id: 4
    Thread: main  ,Thd Id: 1
    Thread: pool-38-thread-1  ,Thd Id: 103
    Thread: Flume Avro RPC Client Call Invoker 1,Thd Id: 105


*Thread Dump After*       
    Thread: Reference Handler  ,Thd Id: 2
    Thread: Finalizer  ,Thd Id: 3
    Thread: Signal Dispatcher  ,Thd Id: 4
    Thread: main  ,Thd Id: 1
    Thread: Avro NettyTransceiver I/O Worker 1  ,Thd Id: 2106
{quote}



Here is another case where finalThreadCount =5 & initialThreadCount=5. But 
notice how the threads are not the same before/after.

{quote}
*Thread Dump Before*
    Thread: Reference Handler  ,Thd Id: 2
    Thread: Finalizer  ,Thd Id: 3
    Thread: Signal Dispatcher  ,Thd Id: 4
    Thread: main  ,Thd Id: 1
    Thread: pool-38-thread-1  ,Thd Id: 103

*Thread Dump After*   
    Thread: Reference Handler  ,Thd Id: 2
    Thread: Finalizer  ,Thd Id: 3
    Thread: Signal Dispatcher  ,Thd Id: 4
    Thread: main  ,Thd Id: 1
    Thread: Avro NettyTransceiver I/O Worker 1  ,Thd Id: 2105
{quote}



> Sporadic failures in  TestNettyAvroRpcClient.spinThreadsCrazily()
> -----------------------------------------------------------------
>
>                 Key: FLUME-2159
>                 URL: https://issues.apache.org/jira/browse/FLUME-2159
>             Project: Flume
>          Issue Type: Bug
>          Components: Test
>    Affects Versions: v1.4.0
>         Environment: centos 5
>            Reporter: Roshan Naik
>              Labels: sdk, test
>         Attachments: FLUME-2159.patch, FLUME-2159.v2.patch
>
>
> TestNettyAvroRpcClient.spinThreadsCrazily() checks to see if the active 
> thread count at the end is the same as the count when it started. I see that 
> once in while the count is off by 1 due to a thread taking a bit longer to 
> wind up. 



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to