----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14569/#review27428 -----------------------------------------------------------
Hey Venkatesh, sorry about this, Jeff originally had a test in his patch but I screwed up and missed it in my git commit. I corrected that, so please rebase your changes on top of TestSyslogTcpSource.java from FLUME-1666. Thanks! - Mike Percy On Oct. 20, 2013, 6:23 p.m., Venkatesh Sivasubramanian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14569/ > ----------------------------------------------------------- > > (Updated Oct. 20, 2013, 6:23 p.m.) > > > Review request for Flume. > > > Bugs: Flume-2120 > https://issues.apache.org/jira/browse/Flume-2120 > > > Repository: flume-git > > > Description > ------- > > Pls. find the patch attached for the FLUME-2120. > > I have made changes to SyslogUDPSource and SyslogTCPSource. Tested it locally > and also have added a JUnit for SyslogUDPSource. > I see the MultiportSyslogTCPSource is pretty much a better version/likely > replacement for SyslogTCPSource. But still went ahead and added the metrics > counters to SyslogTCPSource, as the change was straight forward and its very > much a part of the code base. > > > Diffs > ----- > > flume-ng-core/src/main/java/org/apache/flume/source/SyslogTcpSource.java > 7a12d27 > flume-ng-core/src/main/java/org/apache/flume/source/SyslogUDPSource.java > 96a9e85 > > flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogTCPSource.java > PRE-CREATION > > flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUdpSource.java > eae26ed > > Diff: https://reviews.apache.org/r/14569/diff/ > > > Testing > ------- > > JUnit added for SyslogUDPSource and SyslogTcpSource > > > Thanks, > > Venkatesh Sivasubramanian > >
