-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14989/
-----------------------------------------------------------
Review request for Flume.
Bugs: FLUME-1281 and FLUME-1892
https://issues.apache.org/jira/browse/FLUME-1281
https://issues.apache.org/jira/browse/FLUME-1892
Repository: flume-git
Description
-------
Patch to fix
FLUME-1281 - No test case exists for flume-irc-sink
FLUME-1892 - IRC Sink NPE
#1 Added test class for testing IRC Sink
#2 Added null check for splitlines properties, defaulting it to false
Diffs
-----
flume-ng-sinks/flume-irc-sink/src/main/java/org/apache/flume/sink/irc/IRCSink.java
8e77218
flume-ng-sinks/flume-irc-sink/src/test/java/org/apache/flume/sink/irc/TestIRCSink.java
e69de29
flume-ng-sinks/flume-irc-sink/src/test/resources/log4j.properties e69de29
Diff: https://reviews.apache.org/r/14989/diff/
Testing
-------
#1 Test class
#2 Added test case testIRCSinkMissingSplitLineProperty(), to validate
functionality. If the property is missing, it defaults to false
Thanks,
Ashish Paliwal
