----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15683/#review29223 -----------------------------------------------------------
flume-ng-sdk/src/main/java/org/apache/flume/api/NettyAvroRpcClient.java <https://reviews.apache.org/r/15683/#comment56362> Minor one, would be good to use camel case for variable name - maxIoWorkerStr flume-ng-sdk/src/main/java/org/apache/flume/api/RpcClientConfigurationConstants.java <https://reviews.apache.org/r/15683/#comment56361> Minor one, Can we name variable in camel case like maxIoWorker? Looks good otherwise. - Ashish Paliwal On Nov. 19, 2013, 8:30 p.m., Cameron Gandevia wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15683/ > ----------------------------------------------------------- > > (Updated Nov. 19, 2013, 8:30 p.m.) > > > Review request for Flume. > > > Bugs: FLUME-2238 > https://issues.apache.org/jira/browse/FLUME-2238 > > > Repository: flume-git > > > Description > ------- > > Provide option to configure worker threads in NettyAvroRpcClient > > > Diffs > ----- > > flume-ng-doc/sphinx/FlumeUserGuide.rst 0f12427 > flume-ng-sdk/src/main/java/org/apache/flume/api/NettyAvroRpcClient.java > 9aabdd4 > > flume-ng-sdk/src/main/java/org/apache/flume/api/RpcClientConfigurationConstants.java > 7aa70cb > flume-ng-sdk/src/test/java/org/apache/flume/api/TestNettyAvroRpcClient.java > bfb1fa6 > > Diff: https://reviews.apache.org/r/15683/diff/ > > > Testing > ------- > > > Thanks, > > Cameron Gandevia > >
