[ 
https://issues.apache.org/jira/browse/FLUME-2255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13838570#comment-13838570
 ] 

Mike Percy commented on FLUME-2255:
-----------------------------------

Hari, looks pretty good but can you take out the first sleep? If we need an 
arbitrary sleep() for anything other than burning too much CPU while in a loop, 
then it's a flaky test.

The test is also a little complicated, I wonder if instead we could do 
something like:

{noformat}
source.start();

// Make sure the Channel fills and the Source fails a put-transaction before 
continuing.
while (!source.hitChannelException()) {
  Thread.sleep(50);
}

// Now, make sure the source still works. Read all of the events.
while (numEventsTaken < numEventsPut) {
  // Clear the channel and increment our counters
  Thread.sleep(50);
}
{noformat}

> Spooling Directory Source cannot handle channel exceptions
> ----------------------------------------------------------
>
>                 Key: FLUME-2255
>                 URL: https://issues.apache.org/jira/browse/FLUME-2255
>             Project: Flume
>          Issue Type: Bug
>            Reporter: Hari Shreedharan
>            Assignee: Hari Shreedharan
>         Attachments: FLUME-2255-1.patch, FLUME-2255-2.patch, 
> FLUME-2255-3.patch, FLUME-2255.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to