----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15994/#review29736 -----------------------------------------------------------
flume-ng-sources/flume-ng-kafka-source/src/main/java/org/apache/flume/source/kafka/KafkaSource.java <https://reviews.apache.org/r/15994/#comment57205> Add class level comment with all exposed configuration. flume-ng-sources/flume-ng-kafka-source/src/main/java/org/apache/flume/source/kafka/KafkaSource.java <https://reviews.apache.org/r/15994/#comment57188> You can remove this comment flume-ng-sources/flume-ng-kafka-source/src/main/java/org/apache/flume/source/kafka/KafkaSource.java <https://reviews.apache.org/r/15994/#comment57201> Will it contain only single message entry? (i am new to kafka) flume-ng-sources/flume-ng-kafka-source/src/main/java/org/apache/flume/source/kafka/KafkaSource.java <https://reviews.apache.org/r/15994/#comment57204> Error message can be re-phrased flume-ng-sources/flume-ng-kafka-source/src/main/java/org/apache/flume/source/kafka/KafkaSource.java <https://reviews.apache.org/r/15994/#comment57202> Add a validation for topic, if it is mandtory configuration flume-ng-sources/flume-ng-kafka-source/src/main/java/org/apache/flume/source/kafka/KafkaSource.java <https://reviews.apache.org/r/15994/#comment57190> dont call e.prinStackTrace(), you can log error message with exception flume-ng-sources/flume-ng-kafka-source/src/main/java/org/apache/flume/source/kafka/KafkaSource.java <https://reviews.apache.org/r/15994/#comment57203> better to add validation flume-ng-sources/flume-ng-kafka-source/src/main/java/org/apache/flume/source/kafka/KafkaSourceUtil.java <https://reviews.apache.org/r/15994/#comment57189> same log will be printed in getKafkaConfigProperties, can be removed either one place - Gopinathan Andavar On Dec. 4, 2013, 5:50 a.m., Frank Yao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15994/ > ----------------------------------------------------------- > > (Updated Dec. 4, 2013, 5:50 a.m.) > > > Review request for Flume. > > > Bugs: Kafka and Source > https://issues.apache.org/jira/browse/Kafka > https://issues.apache.org/jira/browse/Source > > > Repository: flume-git > > > Description > ------- > > Add Kafka(0.7.2) Source to flume-1.4, I'm using in our company for half year. > In my performance test, 100k message per second for 10 kafka sources is okay. > > > Diffs > ----- > > flume-ng-sources/flume-ng-kafka-source/pom.xml PRE-CREATION > > flume-ng-sources/flume-ng-kafka-source/src/main/java/org/apache/flume/source/kafka/KafkaSource.java > PRE-CREATION > > flume-ng-sources/flume-ng-kafka-source/src/main/java/org/apache/flume/source/kafka/KafkaSourceUtil.java > PRE-CREATION > > flume-ng-sources/flume-ng-kafka-source/src/test/java/org/apache/flume/source/kafka/KafkaSourceTest.java > PRE-CREATION > > flume-ng-sources/flume-ng-kafka-source/src/test/java/org/apache/flume/source/kafka/KafkaSourceUtilTest.java > PRE-CREATION > flume-ng-sources/flume-ng-kafka-source/src/test/resources/log4j.properties > PRE-CREATION > > Diff: https://reviews.apache.org/r/15994/diff/ > > > Testing > ------- > > Unitests are written whti JUnit and mockito. > > > Thanks, > > Frank Yao > >
