[ 
https://issues.apache.org/jira/browse/FLUME-2127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13842035#comment-13842035
 ] 

Hari Shreedharan commented on FLUME-2127:
-----------------------------------------

This patch seems to be a diff patch with some previously uncommitted code 
(there is code that is being removed that is not in trunk like the @Author 
tag). Also without having a secure mechanism (and not relying on the user to 
use JMX security), I don't feel comfortable with doing this.

> JMX shutdown command for Flume
> ------------------------------
>
>                 Key: FLUME-2127
>                 URL: https://issues.apache.org/jira/browse/FLUME-2127
>             Project: Flume
>          Issue Type: Bug
>          Components: Node, Windows
>    Affects Versions: v1.4.0
>            Reporter: Roshan Naik
>            Assignee: Roshan Naik
>              Labels: jmx, jmx_interface, windows
>             Fix For: v1.4.1, v1.5.0
>
>         Attachments: FLUME-2127.patch
>
>
> There is a problem when the "integration tests" are attempting to stop flume 
> on  Windows using Process.destroy(). This does a brute force kill of the top 
> level shell (running the startup script) which then leaves a child java 
> process (i.e flume agent) running. 
> The brute force kill does not allow the shell to terminate the child java 
> process. Maven somehow notices that child processes are running and waits 
> indefinitely for them to terminate... causing a hang.
> Suggestion is to implement a shutdown command support using JMX. This gives 
> the integration tests a graceful mechanism to terminate flume. Also in 
> production use cases this mechanism can be secured with authentication etc.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to