----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16107/#review29965 -----------------------------------------------------------
Brock, This looks almost ready to go. There is one issue though, which is with regards to the directory being deleted. flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FlumeEventQueue.java <https://reviews.apache.org/r/16107/#comment57461> This line throws an exception if the directory does not already exist. We should add a check to ensure it exists and is a directory. Here is the exception from the test: Running org.apache.flume.channel.file.TestCheckpoint Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.217 sec <<< FAILURE! testSerialization(org.apache.flume.channel.file.TestCheckpoint) Time elapsed: 159 sec <<< ERROR! java.lang.IllegalArgumentException: /var/folders/yn/g7q3wr0n6891lckwvn01s9080000gn/T/queueset6077057550764101389 is not a directory at org.apache.commons.io.FileUtils.cleanDirectory(FileUtils.java:1388) at org.apache.commons.io.FileUtils.deleteDirectory(FileUtils.java:1331) at org.apache.flume.channel.file.FlumeEventQueue.<init>(FlumeEventQueue.java:87) at org.apache.flume.channel.file.TestCheckpoint.testSerialization(TestCheckpoint.java:54) - Hari Shreedharan On Dec. 8, 2013, 5:11 p.m., Brock Noland wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16107/ > ----------------------------------------------------------- > > (Updated Dec. 8, 2013, 5:11 p.m.) > > > Review request for Flume and Hari Shreedharan. > > > Bugs: FLUME-2155 > https://issues.apache.org/jira/browse/FLUME-2155 > > > Repository: flume-git > > > Description > ------- > > Adds a temporary btree based set of entries in the FEQ to check before doing > a linear scan during full replay. > > > Diffs > ----- > > flume-ng-channels/flume-file-channel/pom.xml e055d8a > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/CheckpointRebuilder.java > 7883d0e > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/EventQueueBackingStoreFile.java > 2366cbc > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FileChannel.java > 36f150b > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FlumeEventQueue.java > ac03fb4 > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/Log.java > 8a8cb7f > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/LogFile.java > 62f68c6 > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/ReplayHandler.java > c8f5fdd > > flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestCheckpoint.java > 1e0230d > > flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestCheckpointRebuilder.java > 536af54 > > flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestEventQueueBackingStoreFactory.java > dfb3bf9 > > flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFlumeEventQueue.java > 203cbf2 > pom.xml 267925f > > Diff: https://reviews.apache.org/r/16107/diff/ > > > Testing > ------- > > Unit tests pass > > > Thanks, > > Brock Noland > >
