[ 
https://issues.apache.org/jira/browse/FLUME-2130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13843896#comment-13843896
 ] 

Hari Shreedharan commented on FLUME-2130:
-----------------------------------------

Hi Ashish,

Thanks for the patch. I have some comments on this patch. Looks like this patch 
creates a ByteArrayOutputStream with initial size of 64K - similarly for the 
AdaptiveReceiveBufferSizePredictorFactory. I think we should start with a 
smaller buffer - probably at 2K and set the max to 64K. 
So this can be AdaptiveReceiveBufferSizePredictorFactory (2048, 2048, 65536) 
and the ByteArrayOutputStream can be created using the current code itself. 
When the message is received, the current code already sets the maxSize to the 
event size. 

I think the only change required to the original code is to use 
AdaptiveReceiveBufferSizePredictorFactory, but created with smaller buffer 
values. We can maybe ask the user for hints through config on average event 
size, but I doubt it is necessary.

> Handle larger payloads via SyslogUDPSource
> ------------------------------------------
>
>                 Key: FLUME-2130
>                 URL: https://issues.apache.org/jira/browse/FLUME-2130
>             Project: Flume
>          Issue Type: Improvement
>    Affects Versions: v1.2.0, v1.3.0, v1.4.0
>            Reporter: Roman Scherer
>            Assignee: Ashish Paliwal
>         Attachments: 
> 0001-Handle-larger-UDP-payloads-via-SyslogUDPSource.patch, FLUME-2130-0.patch
>
>
> Syslog messages sent via UDP can contain a payload up to 65507 bytes. 
> Payloads more than 768 bytes are currently truncated because the Netty's 
> buffer size set to this value.



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

Reply via email to