-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16215/
-----------------------------------------------------------

Review request for Flume.


Bugs: FLUME-2186
    https://issues.apache.org/jira/browse/FLUME-2186


Repository: flume-git


Description
-------

Added null check for rpcClient before append().
Added activateOptions() code if unsafeMode is true, to reconnect.

Solution is not very clean as activateOptions() shall be called as many times 
as append() is called. In absence of this, reconnect cannot happen, as null 
check would succeed and return in append()


Diffs
-----


Diff: https://reviews.apache.org/r/16215/diff/


Testing
-------

Test cases exist for the failure. Not added for this case, reference has to be 
null, after initial null check at the beginning of append(). Not sure of a 
clean way to do this.


Thanks,

Ashish Paliwal

Reply via email to