----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16216/#review30314 -----------------------------------------------------------
This looks good. Could you also add a unit test for this? You could write a dummy serializer which throws an exception the first time and then behaves normally (you could extend the Simple serializer and check if it is the first time it is being called, throw else just call super.getIncrements etc). - Hari Shreedharan On Dec. 12, 2013, 4:09 p.m., Gopinathan Andavar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16216/ > ----------------------------------------------------------- > > (Updated Dec. 12, 2013, 4:09 p.m.) > > > Review request for Flume. > > > Bugs: FLUME-2259 > https://issues.apache.org/jira/browse/FLUME-2259 > > > Repository: flume-git > > > Description > ------- > > Transcation is not getting closed in error scenario. > > > Diffs > ----- > > > flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/HBaseSink.java > d5996c3 > > Diff: https://reviews.apache.org/r/16216/diff/ > > > Testing > ------- > > > Thanks, > > Gopinathan Andavar > >
