[
https://issues.apache.org/jira/browse/FLUME-2243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13848156#comment-13848156
]
Ashish Paliwal commented on FLUME-2243:
---------------------------------------
True Hari! I had the same issue, but since I was not sure where I could put it,
I copied it. There were other instances where I faced same issue, mostly with
methods for reuse (findFreePort() is a good example).
I shall update the patch based on your suggestion. Will move the code out and
update the usage in both classes.
> AvroSource to use TransceiverThreadFactory for Thread naming while
> initializing NioServerSocketChannelFactory
> -------------------------------------------------------------------------------------------------------------
>
> Key: FLUME-2243
> URL: https://issues.apache.org/jira/browse/FLUME-2243
> Project: Flume
> Issue Type: Improvement
> Components: Sinks+Sources
> Affects Versions: v1.4.0
> Reporter: Ashish Paliwal
> Assignee: Ashish Paliwal
> Priority: Minor
> Attachments: FLUME-2243-0.patch
>
>
> Currently in Avro source, we use
> socketChannelFactory = new NioServerSocketChannelFactory
> (Executors .newCachedThreadPool(), Executors.newCachedThreadPool());
> This would create generic Thread names like pool-1-thread-1. It would be good
> to use a ThreadFactory, like we use in NettyAvroRpcClient for better
> identification of Threads in log file
> ExecutorService bossExecutor = Executors.newCachedThreadPool(new
> TransceiverThreadFactory(
> "Avro " + NettyTransceiver.class.getSimpleName() + " Boss"));
> ExecutorService workerExecutor = Executors.newCachedThreadPool(new
> TransceiverThreadFactory(
> "Avro " + NettyTransceiver.class.getSimpleName() + " I/O Worker"));
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
