[
https://issues.apache.org/jira/browse/FLUME-2284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13859377#comment-13859377
]
Bruno Mahé commented on FLUME-2284:
-----------------------------------
Some comments on the patch:
* flume-ng-sinks/flume-http-server-sink/pom.xml dependencies have some typo. I
see flume-ng-core 1.4.0. You should also reuse the versions and dependencies
from the main pom.xml.
* In ServerSink.java, it would be great to have constants. Example
"server.http.port" and 1337
* Other strings like "http://%s:%d"; should also be constant
Note that Apache Flume community is still discussing whether or not components
(sources, sinks, channels) should live in Apache Flume or outside (ie. Github).
See threads:
http://mail-archives.apache.org/mod_mbox/flume-dev/201311.mbox/%[email protected]%3E
http://mail-archives.apache.org/mod_mbox/flume-dev/201312.mbox/%3CF535374622774A37BEF978567F75A416%40cloudera.com%3E
> Accept submission of HTTP server sink
> -------------------------------------
>
> Key: FLUME-2284
> URL: https://issues.apache.org/jira/browse/FLUME-2284
> Project: Flume
> Issue Type: Improvement
> Reporter: Joshua Hyde
> Attachments: flume-2284.2013-12-26.1042.diff
>
>
> I've written a Flume sink that exposes the events it receives via an HTTP
> server:
> https://github.com/jrh3k5/flume-http-server-sink
> This helps in integration testing of sources and channels that a developer
> may write for themselves. I'd like to make this part of the official Flume
> platform. What are the guidelines for submitting code like this? I'm afraid I
> wasn't able to find any guidelines on the Flume site itself.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
