Hello all, Would anyone be so kind as to review my patches to fix the following issue:
https://issues.apache.org/jira/browse/FLUME-2215 Please note that I actually submitted two different patches. I know it can seem strange, but while working on a quick fix, I realized that a (hopefully) more elegant way to address the issue would be to redesign the incriminated class: ResettableFileInputStream, separating its responsibilities across different InputStreams and Readers. So I made two patches: "patch0" solves the issue with minimal changes; "patch1" is my redesign proposal. The review requests are: https://reviews.apache.org/r/16516/ (patch0) https://reviews.apache.org/r/16517/ (patch1) A README file for each patch is attached to the Jira ticket. I am totally open to remarks/comments concerning my redesign proposal, please fill free to reply. Regards, Alexandre Dutra
