[ 
https://issues.apache.org/jira/browse/FLUME-2297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tom Wheeler updated FLUME-2297:
-------------------------------

    Attachment: 0001-FLUME-2297-revised-documentation-and-example-for-cus.patch

The attached patch simplifies the example of the custom source in the Flume 
Developer Guide, based on the fact that developers need not create their own 
transactions since the ChannelProcessor.processEvent method handles this for 
them.

> Custom Source Example in Developer Guide Uses Unnecessary Transaction
> ---------------------------------------------------------------------
>
>                 Key: FLUME-2297
>                 URL: https://issues.apache.org/jira/browse/FLUME-2297
>             Project: Flume
>          Issue Type: Bug
>          Components: Docs
>    Affects Versions: v1.4.0
>         Environment: Any Web browser
>            Reporter: Tom Wheeler
>            Priority: Minor
>         Attachments: 
> 0001-FLUME-2297-revised-documentation-and-example-for-cus.patch
>
>
> The custom source in the Flume Developer's guide shows the use of a 
> transaction in the process() method:
>      http://flume.apache.org/FlumeDeveloperGuide.html#source
> I think this is unnecessarily complex and makes a poor example.  Since 
> ChannelProcessor.processEvent also wraps everything in a transaction, the 
> transaction inside the source itself is redundant. This issue requests the 
> example be simplified to only what's really needed.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to