[
https://issues.apache.org/jira/browse/FLUME-2251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13902837#comment-13902837
]
Hari Shreedharan commented on FLUME-2251:
-----------------------------------------
Here is an initial review of this patch:
* please use tab size = 2 spaces (please don't use tab characters, but use tab
size = 2 - most IDEs can convert tabs into a configurable number of spaces).
* The ASF header used contains copyright to the author. Please use the exact
header found in other files in Flume.
* The sink logic seems a bit buggy. Looks like you are rolling back the
transaction if the channel returns null. You rollback the transaction only when
the channel throws an exception or the kafka producer fails. The channel will
return null when there are no more events. Simply commit the transaction and
return READY at that point.
* you need to put a try catch around the rollback call too (since exceptions
can be thrown from this too). Simply catch it and log it.
> Add support for Kafka Sink
> --------------------------
>
> Key: FLUME-2251
> URL: https://issues.apache.org/jira/browse/FLUME-2251
> Project: Flume
> Issue Type: Sub-task
> Components: Sinks+Sources
> Affects Versions: v1.4.0
> Reporter: Ashish Paliwal
> Priority: Minor
> Attachments: FLUME-2251-0.patch, FLUME-2251.patch
>
>
> Add support for Kafka Sink
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
