[ 
https://issues.apache.org/jira/browse/FLUME-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Muhammad Ehsan ul Haque updated FLUME-2350:
-------------------------------------------

    Attachment: FLUME-2350-0.patch

I have added patch for the fix of lexicographical comparison. Apologize for 
making that a bit obscure in the previous patch which made you do the change 
yourself.

I have also added time gaps in two of the tests "testConsumeFileOldest" and 
"testConsumeFileYoungest", just to make it more explicit.
Also added two more test to explicitly test the lexicographical order in case 
of YOUNGEST and OLDEST. (If they look redundant then you may remove as well)

For the tests "testLargeNumberOfFilesOLDEST" and 
"testLargeNumberOfFilesYOUNGEST" I don't think that we need to add any time 
gaps. The test will take very long and also I think it is a good case for 
testing lexicographical ordering as well.

> Consume Order tests need to space out file creation
> ---------------------------------------------------
>
>                 Key: FLUME-2350
>                 URL: https://issues.apache.org/jira/browse/FLUME-2350
>             Project: Flume
>          Issue Type: Bug
>            Reporter: Hari Shreedharan
>         Attachments: FLUME-2350-0.patch
>
>
> Since the files end up getting created almost at the same time, their 
> timestamps end up not being different even though they are created one after 
> another. We need to add sleeps or make sure their last modified is different 
> by adding 1 or 2 seconds to each consecutive file.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to