[
https://issues.apache.org/jira/browse/FLUME-2401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14055356#comment-14055356
]
Hari Shreedharan commented on FLUME-2401:
-----------------------------------------
HI Abe,
Thanks for the patch! This looks good to go. I have only 2 minor comments:
* the compressBackupCheckpoint field in Log class can be made final.
* There are a lot of new/modified lines of code longer than 80 characters.
Could you make sure that these lines are <= 80 chars long? Don't worry about
old code, just the new lines you added (Eclipse/Intellij can do this for you)
Once you have done this, please submit a new patch - I will commit it. Thanks!
> Optionally Compress Backup Checkpoint
> -------------------------------------
>
> Key: FLUME-2401
> URL: https://issues.apache.org/jira/browse/FLUME-2401
> Project: Flume
> Issue Type: Improvement
> Components: File Channel
> Affects Versions: v1.4.0, v1.5.0
> Reporter: Abraham Fine
> Priority: Minor
> Fix For: v1.6.0
>
> Attachments: compress_backup_checkpoint.patch,
> compress_backup_checkpoint_new_tests.patch
>
>
> File Channels with a large capacity create big checkpoint files. If the
> channel is mostly empty when the backup checkpoint is written the file will
> be large but mostly '0'. It would be nice to be able to optionally compress
> the checkpoint to reduce disk utilization for the backup checkpoint.
> See:
> http://mail-archives.apache.org/mod_mbox/flume-user/201406.mbox/%3C8B094F7E897248E89C8E55526178FD65%40cloudera.com%3E
--
This message was sent by Atlassian JIRA
(v6.2#6252)
