[
https://issues.apache.org/jira/browse/FLUME-1793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14060618#comment-14060618
]
li xiang commented on FLUME-1793:
---------------------------------
Hi Edward, I updated a new patch FLUME-1793-1.patch. The following 4 changes
are included
1. For testRoundTrip()
(1) Use GSON, to make assertion ignore ordering
(2) Add indents when building the expected result, to improve the readability,
no logic is changed
2. For shouldHandleInvalidJSONDuringComplexParsing()
(1) Use GSON, to make assertion ignore ordering
(2) Add indents when building the expected result, to improve the readability,
no logic is changed
> Unit test TestElasticSearchLogStashEventSerializer fails with IBM JDK
> ---------------------------------------------------------------------
>
> Key: FLUME-1793
> URL: https://issues.apache.org/jira/browse/FLUME-1793
> Project: Flume
> Issue Type: Bug
> Components: Sinks+Sources, Test
> Affects Versions: v1.3.0
> Environment: IBM Java 6 SR 12
> RHEL 6.3
> Reporter: Aline Guedes Pinto
> Priority: Minor
> Labels: test-patch
> Attachments: FLUME-1793-1.patch, FLUME-1793.patch
>
>
> TestElasticSearchLogStashEventSerializer fails with IBM JDK:
> testRoundTrip(org.apache.flume.sink.elasticsearch.TestElasticSearchLogStashEventSerializer)
> Time elapsed: 0.201 sec <<< FAILURE!
> org.junit.ComparisonFailure:expected:<...p/test","@fields":{"[timestamp":"1355151725225","src_path":"/tmp/test","host":"test@localhost","headerNameTwo":"headerValueTwo","source":"flume_tail_src","headerNameOne":"headerValueOne","type":"sometyp]e"}}^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@...>
> but
> was:<...p/test","@fields":{"[src_path":"/tmp/test","headerNameTwo":"headerValueTwo","timestamp":"1355151725225","host":"test@localhost","type":"sometype","source":"flume_tail_src","headerNameOne":"headerValueOn]e"}}^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@...>
> The values on the "@fields" element are the same as expected, but the order
> is different. This test case works with SUN Java though - it seems like
> HashMap on IBM Java and SUN Java return values in different orders, and the
> test case is counting on order. Order shouldn't matter when using a hashmap
> though.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
