----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23456/#review49405 -----------------------------------------------------------
Couple of points. - From a monitoring standpoint, it is more useful to have a putCommit bytes & takeCommit bytes. instead of putBytes & putCommitBytes. - The computation of event size is incorrect. It should be eventSize =bodySize + headerSize. So the reported metric will be inaccurate. Also incorporating event header's size into this will be expensive. - Roshan Naik On July 14, 2014, 6:53 p.m., Shreyas Subramanya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23456/ > ----------------------------------------------------------- > > (Updated July 14, 2014, 6:53 p.m.) > > > Review request for Flume. > > > Bugs: FLUME-2413 > https://issues.apache.org/jira/browse/FLUME-2413 > > > Repository: flume-git > > > Description > ------- > > Add a new metric for the number of bytes transferred on a flume channel > > > Diffs > ----- > > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FileChannel.java > 0f242d2 > > flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFileChannelMetrics.java > PRE-CREATION > flume-ng-core/src/main/java/org/apache/flume/channel/MemoryChannel.java > b84a3e0 > > flume-ng-core/src/main/java/org/apache/flume/channel/PseudoTxnMemoryChannel.java > cc391c4 > > flume-ng-core/src/main/java/org/apache/flume/instrumentation/ChannelCounter.java > 9938c0a > > flume-ng-core/src/main/java/org/apache/flume/instrumentation/ChannelCounterMBean.java > 9be8c3c > > flume-ng-core/src/test/java/org/apache/flume/channel/TestChannelMetrics.java > PRE-CREATION > > flume-ng-core/src/test/java/org/apache/flume/instrumentation/TestMonitoredCounterGroup.java > b1f637f > > Diff: https://reviews.apache.org/r/23456/diff/ > > > Testing > ------- > > Implemented and ran junit test cases. Also implemented and tested in our > product. > > > Thanks, > > Shreyas Subramanya > >
