----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16437/#review49634 -----------------------------------------------------------
flume-ng-node/src/main/java/org/apache/flume/node/Application.java <https://reviews.apache.org/r/16437/#comment86887> Minor nit: Could factor this and line 300 out since they are invariant of the condition. flume-ng-node/src/main/java/org/apache/flume/node/ZookeeperConfigurationProvider.java <https://reviews.apache.org/r/16437/#comment86886> The Application only subscribes to MaterializedConfiguration events via the EventBus. Posting a FlumeConfiguration will not trigger the update. Has anyone tested that config reloading works? - Zachary Heilbron On Dec. 23, 2013, 9:12 a.m., Ashish Paliwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16437/ > ----------------------------------------------------------- > > (Updated Dec. 23, 2013, 9:12 a.m.) > > > Review request for Flume. > > > Bugs: FLUME-1491 > https://issues.apache.org/jira/browse/FLUME-1491 > > > Repository: flume-git > > > Description > ------- > > Added Zookeeper configuration provider to configure an Agent by reading > properties from Zookeeper. Doc changes are pending > > > Diffs > ----- > > flume-ng-node/pom.xml f1b0c65 > > flume-ng-node/src/main/java/org/apache/flume/node/AbstractConfigurationProvider.java > e63c601 > flume-ng-node/src/main/java/org/apache/flume/node/Application.java 5250139 > > flume-ng-node/src/main/java/org/apache/flume/node/PropertiesFileConfigurationProvider.java > d7438d9 > > flume-ng-node/src/main/java/org/apache/flume/node/ZookeeperConfigurationProvider.java > e69de29 > > flume-ng-node/src/test/java/org/apache/flume/node/TestZookeeperConfigurationProvider.java > e69de29 > pom.xml 3c741c3 > > Diff: https://reviews.apache.org/r/16437/diff/ > > > Testing > ------- > > Added Test cases for Zookeeper provider > > > Thanks, > > Ashish Paliwal > >
