> On Aug. 12, 2014, 11:38 p.m., Zachary Heilbron wrote: > > - Throw an error if both file-based config and ZK-based config are > > configured (or at least a warning). > > - Update the user guide: https://flume.apache.org/FlumeUserGuide.html
- After using this feature, I'd add one very nice-to-have: allow the full path of the conf for the agent to be specified, but default it to <BASE_DIR>/<AGENT_NAME>. Otherwise, for every agent, you must create a path in ZK to host that agent's config file. With this nice-to-have, you can centralize your configuration in a single file and point all agents to the same file. - Zachary ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24398/#review50387 ----------------------------------------------------------- On Aug. 6, 2014, 6 p.m., Zachary Heilbron wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24398/ > ----------------------------------------------------------- > > (Updated Aug. 6, 2014, 6 p.m.) > > > Review request for Flume. > > > Bugs: FLUME-1491 > https://issues.apache.org/jira/browse/FLUME-1491 > > > Repository: flume-git > > > Description > ------- > > Add static and polling ZooKeeper configuration providers > Add test cases > Update command-line usage printout > > > Diffs > ----- > > bin/flume-ng e09e26b > flume-ng-node/pom.xml dce2527 > > flume-ng-node/src/main/java/org/apache/flume/node/AbstractConfigurationProvider.java > e63c601 > > flume-ng-node/src/main/java/org/apache/flume/node/AbstractZooKeeperConfigurationProvider.java > PRE-CREATION > flume-ng-node/src/main/java/org/apache/flume/node/Application.java 5250139 > > flume-ng-node/src/main/java/org/apache/flume/node/PollingZooKeeperConfigurationProvider.java > PRE-CREATION > > flume-ng-node/src/main/java/org/apache/flume/node/PropertiesFileConfigurationProvider.java > d7438d9 > > flume-ng-node/src/main/java/org/apache/flume/node/StaticZooKeeperConfigurationProvider.java > PRE-CREATION > > flume-ng-node/src/test/java/org/apache/flume/node/TestAbstractZooKeeperConfigurationProvider.java > PRE-CREATION > > flume-ng-node/src/test/java/org/apache/flume/node/TestPollingZooKeeperConfigurationProvider.java > PRE-CREATION > > flume-ng-node/src/test/java/org/apache/flume/node/TestStaticZooKeeperConfigurationProvider.java > PRE-CREATION > pom.xml 4bdfcac > > Diff: https://reviews.apache.org/r/24398/diff/ > > > Testing > ------- > > Verified polling ZK config provider in live setup by updating configuration > dynamically and watching the changes take effect > Verified static ZK config provider in live setup by starting with > --no-reload-conf > Verified test cases for polling and static pass > > > Thanks, > > Zachary Heilbron > >
