[ 
https://issues.apache.org/jira/browse/FLUME-2250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gwen Shapira updated FLUME-2250:
--------------------------------
    Attachment: FLUME-2250-3.patch

Many fixes according to [~hshreedharan] comments and few extra:

* Using EventBuilder
* Using isDebugEnabled
* Skipping call to channel in case of no events.
* Moved the creation of Kafka Consumer to start() method. Note that this means 
that if Flume can't connect to ZooKeeper (for any reason - from firewalls and 
typos), start will retry to connect every 3 second.
* Tried to clean up the exceptions. 
One exception ("Failed to create message iterator") is still not very clear. As 
far as I can tell, creating iterator should never fail (and I've never seen it 
fail). The exception is there "just in case", so I don't have useful details to 
add.
* fixed issue with hasData
* chopped up lines
* Improved comments, especially around the Kafka bits.
* Fixed versions in pom
* Parameters that will be passed to Kafka should start with "kafka" (i.e. 
"kafka.zookeeper.connect" rather than "zookeeper.connect"), this makes the 
behavior of Kafka source and sink identical, which is easier for users.
* Added tests for non-existing topics (no errors, just lack of messages) and 
non-existing zookeeper (exception thrown by start() )


> Add support for Kafka Source
> ----------------------------
>
>                 Key: FLUME-2250
>                 URL: https://issues.apache.org/jira/browse/FLUME-2250
>             Project: Flume
>          Issue Type: Sub-task
>          Components: Sinks+Sources
>    Affects Versions: v1.5.0
>            Reporter: Ashish Paliwal
>            Priority: Minor
>         Attachments: FLUME-2250-0.patch, FLUME-2250-1.patch, 
> FLUME-2250-2.patch, FLUME-2250-3.patch, FLUME-2250.patch
>
>
> Add support for Kafka Source



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to