[ 
https://issues.apache.org/jira/browse/FLUME-2468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14136687#comment-14136687
 ] 

Guo Ruijing edited comment on FLUME-2468 at 9/17/14 2:55 AM:
-------------------------------------------------------------

It is nice to fix the issue
1) remove hard code for source code repo.

2) it is easy for flume dev or flume distribution to check version information 
when using git other than git-wip-us.

solution:

1) get branch information in saveVersion.sh.
2) use geturl instead of hardcode in VersionInfo.java
System.out.println("Source code repository: "
+ "https://git-wip-us.apache.org/repos/asf/flume.git";);
+ getUrl() );



was (Author: rguo):
It is nice to fix the issue
1) remove hard code for source code repo.

2) it is easy for flume dev or flume distribution to check version information 
when using git other than git-wip-us.

> Change the source code repo in version info to be the effective one.
> --------------------------------------------------------------------
>
>                 Key: FLUME-2468
>                 URL: https://issues.apache.org/jira/browse/FLUME-2468
>             Project: Flume
>          Issue Type: Improvement
>          Components: Build
>    Affects Versions: v1.5.0.1
>            Reporter: Chunjun Xiao
>            Priority: Minor
>
> The source code repo in flume version info is hard-coded to the official git 
> repo.
> We should fix it to be the effective one.
> {code}
> [root@svm8 ~/rpm/apache-flume-1.5.0.1-bin/bin] # ./flume-ng version
> Flume 1.5.0.1
> Source code repository: https://git-wip-us.apache.org/repos/asf/flume.git
> Revision: ceda6aa1126a01370641caf729d8b1dd6d80aa61
> Compiled by hshreedharan on Tue Jun 10 15:12:04 PDT 2014
> From source with checksum 9500a0fd0084429fe7b0ecf18132be2b
> [root@svm8 ~/rpm/apache-flume-1.5.0.1-bin/bin] #
> {code}
> This line should be fixed:
> {code}
> Source code repository: https://git-wip-us.apache.org/repos/asf/flume.git => 
> <effective repo>
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to