[ 
https://issues.apache.org/jira/browse/FLUME-2250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14136748#comment-14136748
 ] 

Hari Shreedharan commented on FLUME-2250:
-----------------------------------------

+1. I made a bunch of changes related to whitespaces and added a couple of 
isLogDebugEnabled. Running tests and committing.

I have one comment wrt kafka.* parameters. They are out of place compared to 
the other parameters which are camel-cased. I will file a follow-up jira to 
change these params to camel case - the translation should be done within the 
component rather than have two different config conventions within one 
component. This is true for both Kafka Source and Sink.

> Add support for Kafka Source
> ----------------------------
>
>                 Key: FLUME-2250
>                 URL: https://issues.apache.org/jira/browse/FLUME-2250
>             Project: Flume
>          Issue Type: Sub-task
>          Components: Sinks+Sources
>    Affects Versions: v1.5.0
>            Reporter: Ashish Paliwal
>            Priority: Minor
>         Attachments: FLUME-2250-0.patch, FLUME-2250-1.patch, 
> FLUME-2250-2.patch, FLUME-2250-3.patch, FLUME-2250-4.patch, FLUME-2250.patch
>
>
> Add support for Kafka Source



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to