----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26398/#review55902 -----------------------------------------------------------
Ship it! This change is small and good and the tests are good. While I would like to add tests for some of the other reported failures this should not hold up merging this change in. Ship it! - Edward Sargisson On Oct. 6, 2014, 6:16 p.m., Ashish Paliwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26398/ > ----------------------------------------------------------- > > (Updated Oct. 6, 2014, 6:16 p.m.) > > > Review request for Flume. > > > Bugs: FLUME-2126 > https://issues.apache.org/jira/browse/FLUME-2126 > > > Repository: flume-git > > > Description > ------- > > Patch for FLUME-2126, fixes the Complex field addition issue > > > Diffs > ----- > > > flume-ng-sinks/flume-ng-elasticsearch-sink/src/main/java/org/apache/flume/sink/elasticsearch/ContentBuilderUtil.java > bf7c57c > > flume-ng-sinks/flume-ng-elasticsearch-sink/src/test/java/org/apache/flume/sink/elasticsearch/TestElasticSearchSink.java > 15546c1 > > Diff: https://reviews.apache.org/r/26398/diff/ > > > Testing > ------- > > Added Test cases for indexing of JSON event > > > Thanks, > > Ashish Paliwal > >
