[ 
https://issues.apache.org/jira/browse/FLUME-2006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14170503#comment-14170503
 ] 

Hari Shreedharan commented on FLUME-2006:
-----------------------------------------

This generally looks good, but it introduces a dependency on guava in the 
flume-ng-sdk. Looks like it is used only for StringUtils#isNullOrEmpty - you 
can just copy this over to a utils class, to avoid having to bundle guava with 
the sdk.

> in Avro the batch size is called batch-size, in all other sources batchSize
> ---------------------------------------------------------------------------
>
>                 Key: FLUME-2006
>                 URL: https://issues.apache.org/jira/browse/FLUME-2006
>             Project: Flume
>          Issue Type: Bug
>          Components: Sinks+Sources
>    Affects Versions: v1.4.0, v1.3.1
>            Reporter: Alexander Alten-Lorenz
>            Assignee: Ashish Paliwal
>            Priority: Trivial
>         Attachments: FLUME-2006-0.patch
>
>
> http://mail-archives.apache.org/mod_mbox/flume-user/201304.mbox/%[email protected]%3e
> The mismatch is with Avro Sink as well as Thrift sink. Other sinks use 
> batchSize as param name



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to