[
https://issues.apache.org/jira/browse/FLUME-2502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14173014#comment-14173014
]
Hari Shreedharan commented on FLUME-2502:
-----------------------------------------
Patch looks good in general. Minor comments, mostly formatting:
- No spaces after < and before > for generic declarations.
- The { should be on the same line as ) for if conditionals.
- No spaces after ( and before ) in candidateFiles.remove(
candidateFiles.size() - 1 );
- In the if condition, the RANDOM check should be first, since that means you
can avoid the other two tests for non-random cases. In Random cases, all 3
checks are required anyway.
> Spool source's directory listing is inefficient
> -----------------------------------------------
>
> Key: FLUME-2502
> URL: https://issues.apache.org/jira/browse/FLUME-2502
> Project: Flume
> Issue Type: Improvement
> Components: Sinks+Sources
> Affects Versions: v1.5.0
> Reporter: Prateek Rungta
> Attachments: FLUME-2502-0.patch, FLUME-2502-1.patch
>
>
> As mentioned in
> [FLUME-2309|https://issues.apache.org/jira/browse/FLUME-2309], the directory
> listing can it self become the bottleneck when accessing directories with a
> large number of files (>1M). The fix in that JIRA added in the ability to
> specify `RANDOM` as a Consume-Order to avoid sorting large lists.
> The slowness of the directory listing is still un-addressed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
