[
https://issues.apache.org/jira/browse/FLUME-2538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14208848#comment-14208848
]
Hari Shreedharan commented on FLUME-2538:
-----------------------------------------
I like the patch, but I'd recommend not accepting both. We should make sure
that pre-JDK 8 the old string is valid and for JDK 8 it will be the new string.
You can get the java version from the system property - java.version.
> TestResettableFileInputStream fails on JDK 8
> --------------------------------------------
>
> Key: FLUME-2538
> URL: https://issues.apache.org/jira/browse/FLUME-2538
> Project: Flume
> Issue Type: Bug
> Affects Versions: v1.5.0.1
> Reporter: Johny Rufus
> Assignee: Johny Rufus
> Fix For: v1.6.0
>
> Attachments: FLUME-2538.patch
>
>
> TestResettableFileInputStream.testUtf8DecodeErrorHandlingReplace fails in JDK
> 8
> "testUtf8DecodeErrorHandlingReplace(org.apache.flume.serialization.TestResettableFileInputStream)
> Time elapsed: 6 sec <<< FAILURE!
> org.junit.ComparisonFailure: expected:<...(���)
> NonUnicode: (�[])
> > but was:<...(���)
> NonUnicode: (�[����]) "
> Charsetdecoder.decode has changed in its behavior, as to how it handles
> CodingErrorAction.Replace policy
> Will submit a patch today.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
