----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30139/#review69030 -----------------------------------------------------------
Ship it! Ship It! - Jarek Cecho On Jan. 21, 2015, 9:12 p.m., Hari Shreedharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30139/ > ----------------------------------------------------------- > > (Updated Jan. 21, 2015, 9:12 p.m.) > > > Review request for Flume. > > > Repository: flume-git > > > Description > ------- > > A large number of timeouts can lead to several thousands of messages being > buffered but never removed from the HBaseClient's buffers. This can cause a > major heap spike. So we should close and dereference the HBaseClient if we > hit many failures from the HBase side to clear up the buffers. > > > Diffs > ----- > > > flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/AsyncHBaseSink.java > 1666be4 > > Diff: https://reviews.apache.org/r/30139/diff/ > > > Testing > ------- > > All unit tests pass. > > > Thanks, > > Hari Shreedharan > >
