----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30301/#review72441 -----------------------------------------------------------
flume-ng-core/src/main/java/org/apache/flume/source/ThriftSource.java <https://reviews.apache.org/r/30301/#comment118496> Again, this code can be way simpler no: server = getTThreadSelectorServer() if (server == null) server = getTThreadPoolServer(); getTThreadSelectorServer() { if (enableSSL) return null; ... } getTThreadPoolServer() { if (enableSSL) socket = getSSLSocker() else socket = getNormalSocket() ... } - Hari Shreedharan On Feb. 13, 2015, 8:30 p.m., Johny Rufus John wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30301/ > ----------------------------------------------------------- > > (Updated Feb. 13, 2015, 8:30 p.m.) > > > Review request for Flume. > > > Bugs: FLUME-2574 > https://issues.apache.org/jira/browse/FLUME-2574 > > > Repository: flume-git > > > Description > ------- > > Current Thrift Source/Sink does not have support for SSL. Similar to Avro we > should start supporting SSL for Thrift based communication > > > Diffs > ----- > > flume-ng-core/src/main/java/org/apache/flume/source/ThriftSource.java > 551fe13 > flume-ng-core/src/test/java/org/apache/flume/sink/TestThriftSink.java > fccaede > flume-ng-core/src/test/java/org/apache/flume/source/TestThriftSource.java > 357965f > flume-ng-core/src/test/resources/keystorefile.jks PRE-CREATION > flume-ng-core/src/test/resources/truststorefile.jks PRE-CREATION > flume-ng-sdk/src/main/java/org/apache/flume/api/ThriftRpcClient.java > 6382a0e > flume-ng-sdk/src/test/java/org/apache/flume/api/ThriftTestingSource.java > 63d2fc3 > > Diff: https://reviews.apache.org/r/30301/diff/ > > > Testing > ------- > > mvn clean install -Dhadoop.profile=hbase-98 > > > Thanks, > > Johny Rufus John > >
