----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31186/#review73134 -----------------------------------------------------------
flume-ng-sources/flume-twitter-source/src/main/java/org/apache/flume/source/twitter/TwitterSource.java <https://reviews.apache.org/r/31186/#comment119366> Is it possible to have test cases for this, atleast for validations? flume-ng-sources/flume-twitter-source/src/main/java/org/apache/flume/source/twitter/TwitterSource.java <https://reviews.apache.org/r/31186/#comment119363> Can we please move the strings to constants. It helps in long run. Same for all other properties related to this JIRA flume-ng-sources/flume-twitter-source/src/main/java/org/apache/flume/source/twitter/TwitterSource.java <https://reviews.apache.org/r/31186/#comment119365> How do you handle the condition like proxyHost is present, but not the port. By default these are null. I am not sure how CB would behave, can you please verify at your end? - Ashish Paliwal On Feb. 19, 2015, 12:24 p.m., Erik Schmiegelow wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31186/ > ----------------------------------------------------------- > > (Updated Feb. 19, 2015, 12:24 p.m.) > > > Review request for Flume. > > > Repository: flume-git > > > Description > ------- > > This patch fixes FLUME-2618 by adding support for twitter4j's proxy params > > > Diffs > ----- > > > flume-ng-sources/flume-twitter-source/src/main/java/org/apache/flume/source/twitter/TwitterSource.java > 27b2c3ff3de496e377d2fd65e2fafb37b4692364 > > Diff: https://reviews.apache.org/r/31186/diff/ > > > Testing > ------- > > Tested within a proxy environment with a provy server, ran the junit test > regressions. > > > Thanks, > > Erik Schmiegelow > >
