----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31932/#review76491 -----------------------------------------------------------
+1, looks great, a couple of minor issues flume-tools/src/main/java/org/apache/flume/tools/FileChannelIntegrityTool.java <https://reviews.apache.org/r/31932/#comment124025> Shouldn't this be "Could not find class" ? Also if the handling is the same in all the catch blocks can we collapse them and probably expose the exception encountered to the user flume-tools/src/main/java/org/apache/flume/tools/FileChannelIntegrityTool.java <https://reviews.apache.org/r/31932/#comment124027> totalEvents, validEvents, invalidEvents refer to the Put events processed, should we explicitly mention that these are put events ? Not sure if this scenario is possible, but if there are no put events in the channel and if there are take events that are corrupt then the counts may look like total events - 0 corrupt events - 1 - Johny Rufus John On March 14, 2015, 6:52 a.m., Ashish Paliwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31932/ > ----------------------------------------------------------- > > (Updated March 14, 2015, 6:52 a.m.) > > > Review request for Flume. > > > Bugs: FLUME-2613 > https://issues.apache.org/jira/browse/FLUME-2613 > > > Repository: flume-git > > > Description > ------- > > Fix for Tool/script for deleting individual message from queue > New tool added to validate events and drop onces that do not meet App criteria > > > Diffs > ----- > > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/EventUtils.java > PRE-CREATION > > flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestEventUtils.java > PRE-CREATION > flume-tools/src/main/java/org/apache/flume/tools/EventValidater.java > PRE-CREATION > > flume-tools/src/main/java/org/apache/flume/tools/FileChannelIntegrityTool.java > 1030442 > > flume-tools/src/test/java/org/apache/flume/tools/TestFileChannelIntegrityTool.java > f24ae56 > > Diff: https://reviews.apache.org/r/31932/diff/ > > > Testing > ------- > > Test Cases Added > > > Thanks, > > Ashish Paliwal > >
