[ https://issues.apache.org/jira/browse/FLUME-2595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14487834#comment-14487834 ]
Hari Shreedharan commented on FLUME-2595: ----------------------------------------- [~roshan_naik] - FileChannelIntegrityTool tests still fail: {code} Running org.apache.flume.tools.TestFileChannelIntegrityTool Tests run: 4, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.604 sec <<< FAILURE! testFixCorruptRecordsWithCheckpoint(org.apache.flume.tools.TestFileChannelIntegrityTool) Time elapsed: 148 sec <<< FAILURE! java.lang.AssertionError: expected:<13> but was:<0> at org.junit.Assert.fail(Assert.java:93) at org.junit.Assert.failNotEquals(Assert.java:647) at org.junit.Assert.assertEquals(Assert.java:128) at org.junit.Assert.assertEquals(Assert.java:472) at org.junit.Assert.assertEquals(Assert.java:456) at org.apache.flume.tools.TestFileChannelIntegrityTool.doTestFixCorruptEvents(TestFileChannelIntegrityTool.java:220) at org.apache.flume.tools.TestFileChannelIntegrityTool.testFixCorruptRecordsWithCheckpoint(TestFileChannelIntegrityTool.java:145) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:606) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:45) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:42) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20) at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:28) at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:30) at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:263) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:68) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:47) at org.junit.runners.ParentRunner$3.run(ParentRunner.java:231) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:60) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:229) at org.junit.runners.ParentRunner.access$000(ParentRunner.java:50) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:222) at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:28) at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:30) at org.junit.runners.ParentRunner.run(ParentRunner.java:300) at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:252) at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:141) at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:112) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:606) at org.apache.maven.surefire.util.ReflectionUtils.invokeMethodWithArray(ReflectionUtils.java:189) at org.apache.maven.surefire.booter.ProviderFactory$ProviderProxy.invoke(ProviderFactory.java:165) at org.apache.maven.surefire.booter.ProviderFactory.invokeProvider(ProviderFactory.java:85) at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:115) at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:75) {code} > Add option to checkpoint on file channel shutdown > ------------------------------------------------- > > Key: FLUME-2595 > URL: https://issues.apache.org/jira/browse/FLUME-2595 > Project: Flume > Issue Type: Bug > Components: File Channel > Affects Versions: v1.5.1 > Reporter: Roshan Naik > Assignee: Roshan Naik > Labels: channel > Attachments: FLUME-2595.patch, FLUME-2595.v2.patch, > FLUME-2595.v3.patch > > > Restarting a File channel based agent can take very long, a few hours to > evens days in some cases. The reason being the slow replay performance. > By having the file channel checkpoint on shutdown, this long replay can > avoided as there will be nothing to replay on startup. > A small hit (a few seconds perhaps) will be observed on shutdown to perform > the checkpoint. -- This message was sent by Atlassian JIRA (v6.3.4#6332)