[ 
https://issues.apache.org/jira/browse/FLUME-2646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14492719#comment-14492719
 ] 

Ryan Blue commented on FLUME-2646:
----------------------------------

bq. Should the parseHeader method use the configured delimiter rather than 
always using ,?

I don't think so. I want to be strict about the configuration, but not the 
data. The configuration should always use a reliable delimiter, and it is not 
CSV. For example, commas aren't allowed. I think that's the right way to go 
because configuration should be consistent: you shouldn't need to know the 
other configuration values to understand the header.

bq. When loading a parser based on an event header with the CSV header string, 
should it parse other parsing properties from other event headers rather than 
using the ones configured in the flume.properties file?

If necessary later, we can add this. For now I don't see a valid use that mixes 
CSV delimiters or other settings. The only reason the header is supported is 
that there is a good chance that fields aren't produced in a reliable order. It 
is reasonable for a user to iterate through a map, for example. I don't think 
there is a similarly reasonable use case where the data coming in has different 
delimiters or other CSV characteristics.

> Add JSON and CSV entity parsers to DatasetSink
> ----------------------------------------------
>
>                 Key: FLUME-2646
>                 URL: https://issues.apache.org/jira/browse/FLUME-2646
>             Project: Flume
>          Issue Type: Bug
>          Components: Sinks+Sources
>            Reporter: Ryan Blue
>            Assignee: Ryan Blue
>         Attachments: FLUME-2646.1.diff
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to